Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to skip watting for start command #167

Merged
merged 2 commits into from
Sep 26, 2019

Conversation

FabioMR
Copy link
Contributor

@FabioMR FabioMR commented Feb 19, 2019

I always keep the server running and use VSCode to attach to the active process.
So it is more useful to skip the "wait for a start command" line.

@FabioMR FabioMR closed this Mar 13, 2019
@FabioMR FabioMR reopened this Mar 13, 2019
@Eusebius1920 Eusebius1920 mentioned this pull request Apr 9, 2019
@FabioMR FabioMR closed this Apr 9, 2019
@FabioMR FabioMR reopened this Apr 9, 2019
@iggycoder
Copy link

iggycoder commented Aug 12, 2019

Promoting this feature again since we have now 2 PRs for this - @Eusebius1920 referenced previous PR implementing the same.

Just to give perspective - other debuggers have features to start debugging in waiting or non-waiting mode:

  • Node.js is using command line option
    • --inspect for default debugging or
    • --inspect-brk for waiting until debugger is connected
  • Python Debugger is using command line option
    • --wait for waiting until debugger is connected

Any chance to merge this?

@ViugiNick
Copy link
Collaborator

@iggycoder @FabioMR this PR looks much safer than #145, we'll discuss it

@FabioMR
Copy link
Contributor Author

FabioMR commented Aug 12, 2019

@ViugiNick Sure, we can discuss it. What can i do to get this PR merged in?

@ViugiNick
Copy link
Collaborator

@FabioMR @iggycoder, For now, it remains only to wait for a colleague who has rights to merge PR's in this repo

@iggycoder
Copy link

Any updates regarding the colleague/merge of the PR?

@ViugiNick
Copy link
Collaborator

@FabioMR Could you please clarify, why do you need this change in gemspec?

@FabioMR
Copy link
Contributor Author

FabioMR commented Sep 26, 2019

@ViugiNick It was just to remove a deprecation warning message. If it is a problem, we can change it back.

@ViugiNick ViugiNick merged commit 18a3ba4 into ruby-debug:master Sep 26, 2019
@ViugiNick
Copy link
Collaborator

@FabioMR @iggycoder merged and ruby-debug-ide-0.7.1.beta1 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants